Skip to content

Conversation

@d4l3k
Copy link
Member

@d4l3k d4l3k commented Oct 21, 2025

This fixes the windows build by bumping the libuv version to be compatible with newer versions of cmake.

https://github.com/pytorch/gloo/actions/runs/18698446504/job/53321707849

@meta-cla meta-cla bot added the CLA Signed label Oct 21, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 21, 2025

@d4l3k has imported this pull request. If you are a Meta employee, you can view this in D85191254.

@d4l3k d4l3k force-pushed the d4l3k/fix_windows branch 2 times, most recently from 2c83677 to d1c31e9 Compare October 21, 2025 22:29
@d4l3k d4l3k force-pushed the d4l3k/fix_windows branch 2 times, most recently from 0bb8e45 to e7d4bf3 Compare December 2, 2025 00:56
@d4l3k d4l3k changed the title ci/windows: bump libuv version ci/windows: bump libuv version and fix windows Dec 2, 2025
@d4l3k d4l3k force-pushed the d4l3k/fix_windows branch 7 times, most recently from 7958848 to 32d7563 Compare December 2, 2025 02:15
@d4l3k d4l3k force-pushed the d4l3k/fix_windows branch from 32d7563 to 510ec78 Compare December 2, 2025 02:23
@d4l3k
Copy link
Member Author

d4l3k commented Dec 2, 2025

Internal PR accepted -- landing

@d4l3k d4l3k merged commit 3135b0b into main Dec 2, 2025
8 of 10 checks passed
@d4l3k d4l3k deleted the d4l3k/fix_windows branch December 2, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants