Skip to content
Permalink
Browse files

Update PR Template for better Phabricator parsing

Summary: Pull Request resolved: #2916

Differential Revision: D15349297

Pulled By: jfix71

fbshipit-source-id: 460a7a17f32fd7fad01ca77453d7d8ee0773e252
  • Loading branch information...
jfix71 authored and facebook-github-bot committed May 15, 2019
1 parent 902bc9a commit 0239ff3cc5f8e871ba6eb0af44ec31658d821cef
Showing with 10 additions and 8 deletions.
  1. +4 −5 PULL_REQUEST.md
  2. +6 −3 PULL_REQUEST_TEMPLATE.md
@@ -9,19 +9,19 @@ For example:

Ideally, the same format should be used in the commit message.

# Description
# Summary

The description field should include a more verbose explanation of what this PR does.
The Summary field should include a more verbose explanation of what this PR does.
If this PR causes a change in behavior it should document the behavior before and after.
If it fixes a bug, please, describe what the original issue is and how the change resolves it.

# Formatting

Please, run clang-format before submitting the PR.

# Testing
# Test Plan

The testing section should include an explanation of what testing was done.
The test plan section should include an explanation of what testing was done.
For example unit test, manual testing through stand-alone testing binaries like mnist, cifar10, etc.
Please use your best judgment or ask for guidance if you are unsure what kind of testing is required for a given change.
The riskier the change, the more comprehensive the testing should be.
@@ -41,4 +41,3 @@ This way Github will make sure that underlying referenced issue will be automati

If the purpose of the PR to address issue partially, please, just tag the issue:
* #Issue.

@@ -1,6 +1,9 @@
*Description*:
*Testing*:
*Documentation*:
Summary:

Documentation:

Test Plan:

[Optional Fixes #issue]

Please see a detailed explanation of how to fill out the fields in the relevant sections in PULL_REQUEST.md.

0 comments on commit 0239ff3

Please sign in to comment.
You can’t perform that action at this time.