New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Enable CPU backend on Travis #2318

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@bertmaher
Copy link
Contributor

bertmaher commented Jan 30, 2019

Description: Should work. OpenCL could be added with pocl but I'm not sure it's worth fiddling with now.
Testing: CI
Documentation: n/a

@rdzhabarov

This comment has been minimized.

Copy link
Contributor

rdzhabarov commented Jan 30, 2019

There were some issues with capturing gcov profile iirc (that's why i explicitly disabled CPU backend), I digged a bit but was not able to fix it last time. If you could make it work let's merge this change :)

I'd not worry about OpenCL.

If you are unable to make it work, we could just have a CircleCI (preferable) or Travis target to run gcc without coverage information.

@nadavrot
Copy link
Contributor

nadavrot left a comment

stamp.

@bertmaher bertmaher force-pushed the bertmaher:ci branch from cb3d9d6 to 2936aae Jan 30, 2019

@bertmaher

This comment has been minimized.

Copy link
Contributor Author

bertmaher commented Jan 30, 2019

Seems like it worked... It looks like it doesn't upload coverage from a fork, so let's see what happens if I actually land this.

@bertmaher bertmaher merged commit 6b10261 into pytorch:master Jan 30, 2019

5 checks passed

ci/circleci: ASAN Your tests passed on CircleCI!
Details
ci/circleci: DEBUG Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_WITH_LIT Your tests passed on CircleCI!
Details
ci/circleci: SHARED Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bertmaher bertmaher deleted the bertmaher:ci branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment