Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to foxi #2449

Merged
merged 3 commits into from Feb 27, 2019

Conversation

Projects
None yet
5 participants
@houseroad
Copy link
Member

houseroad commented Feb 26, 2019

Description: Use foxi instead of onnxifi in onnx
Testing: CI
Documentation:
[Optional Fixes #issue]

Please see a detailed explanation of how to fill out the fields in the relevant sections in PULL_REQUEST.md.

@houseroad houseroad force-pushed the houseroad:switch_to_foxi branch 3 times, most recently from 38531b3 to cc82951 Feb 26, 2019

@jackm321

This comment has been minimized.

Copy link
Contributor

jackm321 commented Feb 26, 2019

Haha dang beat me to it #2450
I wasn't aware that you were doing this.
I'll close the other one

@jackm321 jackm321 referenced this pull request Feb 26, 2019

Closed

Use Foxi #2450

@jackm321
Copy link
Contributor

jackm321 left a comment

Looks good!
Can you update Onnxifi.md. Also you'll have to cast the onnxGetExtensionFunctionAddress in foxi to get rid of the error. Maybe do that then update this PR.
Thanks!

endif()
add_subdirectory(${GLOW_THIRDPARTY_DIR}/foxi build_foxi)

This comment has been minimized.

@jackm321

jackm321 Feb 26, 2019

Contributor

This isn't needed for onnx proto, may be better to target_include_directories on Importer? not sure

@houseroad houseroad force-pushed the houseroad:switch_to_foxi branch from cc82951 to a98bdf5 Feb 26, 2019

@houseroad houseroad force-pushed the houseroad:switch_to_foxi branch from ffb9aec to ef41bda Feb 26, 2019

@zrphercule zrphercule self-requested a review Feb 26, 2019

@zrphercule
Copy link
Member

zrphercule left a comment

LGTM! Great work! Just make sure you modified all onnxifi headers.

@jackm321
Copy link
Contributor

jackm321 left a comment

LGTM!

@yinghai yinghai merged commit 37ebe41 into pytorch:master Feb 27, 2019

6 checks passed

ci/circleci: ASAN Your tests passed on CircleCI!
Details
ci/circleci: DEBUG Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_WITH_EXPENSIVE_TESTS Your tests passed on CircleCI!
Details
ci/circleci: SHARED Your tests passed on CircleCI!
Details
ci/circleci: TSAN Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.