[glow-h] Die loudly if !isOpSupported during compilation #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: To fully sanity check our compilation results, check isOpSupported for each node while compiling. Specifically, fp32 convolution is not supported by H and we were silently miscompiling code as a result. Reviewed By: nickg Differential Revision: D14841987
|
As per linked issue, I'm going to close this PR in favor of a more principled fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To fully sanity check our compilation results, check isOpSupported for
each node while compiling. Specifically, fp32 convolution is not supported by
H and we were silently miscompiling code as a result.
Differential Revision: D14841987