Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the emotions_ferplus model in glow. #2713

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
None yet
3 participants
@arunm-git
Copy link
Contributor

arunm-git commented Apr 12, 2019

Description:
Now that we have support for auto_pad == SAME_UPPPER in glow, this model works as-is.
Sample pictures taken from the demo github repo (see README in the EmotionSampleImages folder).

Testing:

ninja all
./tests/images/run.sh
[...]

Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/angry_baby.png	Label-K1: 4 (probability: 3.0380)
Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/angry_man.png	Label-K1: 4 (probability: 3.8409)
Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/fear.png	Label-K1: 6 (probability: 1.5807)
Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/happy.png	Label-K1: 1 (probability: 4.3042)
Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/neutral.png	Label-K1: 0 (probability: 2.1749)
Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/neutral_girl.png	Label-K1: 0 (probability: 4.3364)
Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/sad_baby.png	Label-K1: 3 (probability: 7.2758)
Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/sad_baby2.png	Label-K1: 3 (probability: 6.2101)
Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/surprised_boy.png	Label-K1: 2 (probability: 2.1258)
Model: emotion_ferplus/model.onnx
 File: tests/images/EmotionSampleImages/surprised_woman.png	Label-K1: 2 (probability: 4.1188)

Issues:
Resolves #2504

@jfix71

jfix71 approved these changes Apr 12, 2019

Copy link
Contributor

jfix71 left a comment

Awesome! Couple nits, but LGTM.

Show resolved Hide resolved tests/images/run.sh Outdated
Show resolved Hide resolved utils/download_onnx_models.sh Outdated
Add support for the emotions_ferplus model in glow.
Description
Now that we have support for auto_pad == SAME_UPPPER in glow, this model works as-is.
Sample pictures taken from the demo github repo (see README in the EmotionSampleImages folder).

Testing

ninja all
./tests/images/run.sh

Issues
Resolves #2504

@arunm-git arunm-git force-pushed the arunm-git:ferplus_test branch from 4509378 to 3d527de Apr 12, 2019

@arunm-git arunm-git merged commit b372229 into pytorch:master Apr 13, 2019

6 checks passed

ci/circleci: ASAN Your tests passed on CircleCI!
Details
ci/circleci: DEBUG Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_WITH_EXPENSIVE_TESTS Your tests passed on CircleCI!
Details
ci/circleci: SHARED Your tests passed on CircleCI!
Details
ci/circleci: TSAN Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arunm-git arunm-git deleted the arunm-git:ferplus_test branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.