Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glog cmake configs #2763

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
4 participants
@jackm321
Copy link
Contributor

commented Apr 22, 2019

Description:
Add cmake configs for glog

Testing:
Build on osx
CI on linux

Documentation:
Fixes #2732

@jackm321 jackm321 force-pushed the jackm321:fixGlogBuild branch 4 times, most recently from 9b7f76e to ea5a2d3 Apr 22, 2019

@jackm321 jackm321 force-pushed the jackm321:fixGlogBuild branch from ea5a2d3 to 167ccbc Apr 23, 2019

@jackm321 jackm321 changed the title [WIP] fix glog cmake Add glog cmake Apr 23, 2019

@jackm321 jackm321 changed the title Add glog cmake Add glog cmake configs Apr 23, 2019

@nadavrot

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Sorry for the delay in review LGTM.

@jackm321 jackm321 merged commit 159d99e into pytorch:master Apr 23, 2019

6 checks passed

ci/circleci: ASAN Your tests passed on CircleCI!
Details
ci/circleci: DEBUG Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_WITH_EXPENSIVE_TESTS Your tests passed on CircleCI!
Details
ci/circleci: SHARED Your tests passed on CircleCI!
Details
ci/circleci: TSAN Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ayermolo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Thanks @jackm321!

@jackm321

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@ayermolo no problem, sorry for any issues this has caused.

bosskwei added a commit to bosskwei/glow that referenced this pull request May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.