Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Disable OpenCL support by default. #2808

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
4 participants
@enferex
Copy link
Contributor

commented Apr 27, 2019

Description:
This updated configuration matches the documentation at
https://github.com/pytorch/glow/blob/master/docs/Building.md
Notably, the line:
"By default Glow builds with only the interpreter backend enabled."

It was also mentioned that not everyone has OpenCL installed. I think
it makes sense to not make OpenCL a requirement; however, I can also see
where it might be expected as a requirement. I figured I'd at least put
this PR out for discussion.

Testing:
The unittests should still build and run correctly:
ninja all && ninja test

Fixes #2466

[cmake] Disable OpenCL support by default.
*Description*:
This updated configuration matches the documentation at
https://github.com/pytorch/glow/blob/master/docs/Building.md
Notably, the line:
"By default Glow builds with only the interpreter backend enabled."

It was also mentioned that not everyone has OpenCL installed.  I think
it makes sense to not make OpenCL a requirement; however, I can also see
where it might be expected as a requirement.  I figured I'd at least put
this PR out for discussion.

*Testing*:
The unittests should still build and run correctly:
`ninja all && ninja test`

Fixes #2466
@arunm-git

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Seems reasonable to me. Without this change, I just hit an issue where enabling an opencl backend test failed due to no opencl platforms.

@opti-mix
Copy link
Contributor

left a comment

It's fine to disable it as we still check OpenCL on our CI these days

@rdzhabarov Our POCL-based OpenCL testing is not dependent in this default setting being ON as we explicitly enable OpenCL on CI, right?

arunm-git added a commit to arunm-git/glow that referenced this pull request Apr 29, 2019

Enable HostManagerTest for multiple backends
Description

Replace pow with tanh so the test can be enabled for different backends.

Testing

ninja all && ninja test

(This will fail for opencl if you don't have that setup. But pytorch#2808 will address that)

@arunm-git arunm-git merged commit 9953ba5 into pytorch:master May 1, 2019

5 of 6 checks passed

ci/circleci: DEBUG Your tests failed on CircleCI
Details
ci/circleci: ASAN Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_WITH_EXPENSIVE_TESTS Your tests passed on CircleCI!
Details
ci/circleci: SHARED Your tests passed on CircleCI!
Details
ci/circleci: TSAN Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

bosskwei added a commit to bosskwei/glow that referenced this pull request May 11, 2019

[cmake] Disable OpenCL support by default. (pytorch#2808)
*Description*:
This updated configuration matches the documentation at
https://github.com/pytorch/glow/blob/master/docs/Building.md
Notably, the line:
"By default Glow builds with only the interpreter backend enabled."

It was also mentioned that not everyone has OpenCL installed.  I think
it makes sense to not make OpenCL a requirement; however, I can also see
where it might be expected as a requirement.  I figured I'd at least put
this PR out for discussion.

*Testing*:
The unittests should still build and run correctly:
`ninja all && ninja test`

Fixes pytorch#2466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.