Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] only download resnet50 and en2gr for expensive tests #3030

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@nickgg
Copy link
Contributor

commented May 31, 2019

Summary: We're downloading all models for RELEASE_WITH_EXPENSIVE_TESTS CI build, but looks like we only use resnet and en2gr text translation models.

Documentation:

Test Plan: try to make CI work

@jfix71

jfix71 approved these changes May 31, 2019

Copy link
Contributor

left a comment

🏎

@nickgg nickgg force-pushed the nickgg:downloadLessCI branch from 186310d to f303cb5 May 31, 2019

@nickgg

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

Unfortunately looks like en2gr is the biggest model by a lot so unsure how much we're saving here.

@nickgg nickgg force-pushed the nickgg:downloadLessCI branch from f303cb5 to 407c9f8 May 31, 2019

@facebook-github-bot
Copy link

left a comment

@nickgg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@rdzhabarov
Copy link
Contributor

left a comment

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.