Join GitHub today
[Tracing] change TraceEvent type from fixed size string to char #3080
Summary: TraceEvents have a 1 char type value which we were storing as a string internally. Change to a char to save some memory inside the Runtime.
Documentation: n/a we already export chars through Onnxifi.
Test Plan: unit tests, specifically TraceEventTests.
@jackm321 The thing with an enum is you have to specify all valid options, but we don't support all types in the Trace Event spec. However, it is useful to be able to insert events of a different type sometimes, e.g. as we do in the tracing-compare example to set thread names as Metadata events (type 'M').