[PyTorch] Add support for broadcasting arithmetic ops #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackm321
changed the title
bertmaher
approved these changes
Jul 25, 2019
|
One question: can I always use createNodeWithBroadcast, no matter what node it is? |
zrphercule
approved these changes
Jul 25, 2019
|
@zrphercule no looks like it's just mul, div, add, and sub glow/include/glow/Graph/Graph.h Lines 709 to 712 in f453b64 |
jackm321
force-pushed
the
pt_broadcast_arithmetic_ops
branch
3 times, most recently
from
8b25d14
to
25444ee
Compare
There was a problem hiding this comment.
@jackm321 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jackm321
force-pushed
the
pt_broadcast_arithmetic_ops
branch
from
25444ee
to
5c2d8f1
Compare
There was a problem hiding this comment.
@jackm321 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PyTorch arithmetic ops support multidirectional broadcasting so add this to the loader
Documentation:
doxygen
Test Plan:
added tests