Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Add support for broadcasting arithmetic ops #3269

Closed

Conversation

@jackm321
Copy link
Contributor

commented Jul 19, 2019

Summary:
PyTorch arithmetic ops support multidirectional broadcasting so add this to the loader

Documentation:
doxygen

Test Plan:
added tests

@jackm321 jackm321 requested review from yinghai and zrphercule Jul 19, 2019

@jackm321 jackm321 changed the title Add support for broadcasting arithmetic ops [PyTorch] Add support for broadcasting arithmetic ops Jul 19, 2019

@zrphercule

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

One question: can I always use createNodeWithBroadcast, no matter what node it is?

@jackm321

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

@zrphercule no looks like it's just mul, div, add, and sub

DECLARE_BROADCAST_NODE(Mul, /* NUM_INPUTS */ 2)
DECLARE_BROADCAST_NODE(Div, /* NUM_INPUTS */ 2)
DECLARE_BROADCAST_NODE(Add, /* NUM_INPUTS */ 2)
DECLARE_BROADCAST_NODE(Sub, /* NUM_INPUTS */ 2)

@jackm321 jackm321 force-pushed the jackm321:pt_broadcast_arithmetic_ops branch 3 times, most recently from 8b25d14 to 25444ee Jul 30, 2019

@facebook-github-bot
Copy link

left a comment

@jackm321 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jackm321 jackm321 force-pushed the jackm321:pt_broadcast_arithmetic_ops branch from 25444ee to 5c2d8f1 Jul 31, 2019

@facebook-github-bot
Copy link

left a comment

@jackm321 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jul 31, 2019

@jackm321 merged this pull request in a6f8c39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.