Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelisting option for FP16 conversion #3386

Closed

Conversation

@jfix71
Copy link
Contributor

commented Aug 6, 2019

Summary: Add option to whitelist node kinds for conversion instead of the default blacklist. This makes testing of networks easier.

Test Plan: Added unit test.

@jfix71 jfix71 force-pushed the jfix71:allow_whitelist_fp16_conversion branch from 2408d07 to fedb040 Aug 6, 2019

@jfix71 jfix71 force-pushed the jfix71:allow_whitelist_fp16_conversion branch from fedb040 to e2d1b06 Aug 7, 2019

@facebook-github-bot
Copy link

left a comment

@jfix71 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@beicy

beicy approved these changes Aug 12, 2019

Copy link
Contributor

left a comment

LGTM!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Aug 13, 2019

@jfix71 merged this pull request in ec83604.

@jfix71 jfix71 deleted the jfix71:allow_whitelist_fp16_conversion branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.