Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ExecutionEngine with ExecutionEngine2 [NFC] #3388

Closed
wants to merge 2 commits into from

Conversation

@gcatron
Copy link
Contributor

commented Aug 6, 2019

Summary: This PR replaces the old EE with the new EE2, this removes the old EE and BackendTestUtils and renames EE2 and BackendTestUtils2 to take their place. This PR also updates all instance of EE2 and BackendTestUtils2

Documentation: Coming soon.. There will be a follow up PR to update docs and close the port.

Progress on #3239

Test Plan: Verify everything builds, and unit tests pass. NFC just mechanical.

@facebook-github-bot
Copy link

left a comment

@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jfix71

jfix71 approved these changes Aug 6, 2019

Copy link
Contributor

left a comment

Approving to unblock/avoid conflicts. Great work on all of this, thanks for tackling it!

@jfix71

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Make sure you fix the clang format issues

@gcatron gcatron force-pushed the gcatron:replace_EE_with_EE2 branch from 96e427c to 23f2a4b Aug 6, 2019

@facebook-github-bot
Copy link

left a comment

@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@beicy

beicy approved these changes Aug 6, 2019

Copy link
Contributor

left a comment

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.