Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNXIFI] Add timeouts and statuses to onnxifi events #3400

Closed
wants to merge 1 commit into from

Conversation

@jackm321
Copy link
Contributor

commented Aug 8, 2019

Summary:
see #2702
Add a timeout mechanism and a way to pass onnxStatuses from onnxifi event signallers to waiters. This enables waiting for Glow to return results for only a finite period of time and also enable Glow to pass statuses back to the caller in case a failure has occurred.

Documentation:
doxygen

Test Plan:
CI
These changes are backwards compatible so will make the corresponding changes in c2 in a followup and test the functionality there.

@jackm321 jackm321 force-pushed the jackm321:onnxifi_timeout_events branch 3 times, most recently from 85a33ad to c7ee52a Aug 8, 2019

@jackm321 jackm321 force-pushed the jackm321:onnxifi_timeout_events branch from c7ee52a to 712e08d Aug 8, 2019

@facebook-github-bot
Copy link

left a comment

@jackm321 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jackm321 jackm321 assigned zrphercule and yinghai and unassigned yinghai and zrphercule Aug 9, 2019

@jackm321 jackm321 requested review from zrphercule and yinghai Aug 9, 2019

@yinghai

yinghai approved these changes Aug 9, 2019

Copy link
Contributor

left a comment

LGTM

@facebook-github-bot

This comment has been minimized.

Copy link

commented Aug 9, 2019

@jackm321 merged this pull request in 7a9886f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.