Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted memory-related fixes for HostManager, EE, RecSys #3411

Closed
wants to merge 4 commits into from

Conversation

@jfix71
Copy link
Contributor

commented Aug 13, 2019

4 commits here:

  • When calling ExecutionEngine::clear(), reset the Module
  • Add device memory to the EE constructor so we don't need to reset
  • Use HostManager::removeNetwork() from HostManager::clearHost()
  • Refactor RecSys to make sure EEs are cleared once done and we save only the result tensor to compare against.

@jfix71 jfix71 requested a review from gcatron Aug 13, 2019

@jackm321
Copy link
Contributor

left a comment

Thanks for breaking these up into multiple commits @jfix71.
LGTM

@gcatron
Copy link
Contributor

left a comment

LGTM thanks for breaking it down into separate diffs!

@jfix71 jfix71 force-pushed the jfix71:recsys_refactor_decrease_mem branch from e0d7345 to 734a848 Aug 13, 2019

@facebook-github-bot
Copy link

left a comment

@jfix71 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

@jfix71 merged this pull request in 4c6e53e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.