Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Fix pytorch build #3441

Closed
wants to merge 1 commit into from

Conversation

@jackm321
Copy link
Contributor

commented Aug 20, 2019

Summary:
See title

Documentation:
none

Test Plan:
python setup.py test
CI

@gcatron
Copy link
Contributor

left a comment

LGTM

@jackm321 jackm321 force-pushed the jackm321:fix_pt branch from d675c2f to 9f61e37 Aug 21, 2019

@@ -128,7 +128,6 @@ elif [[ "$CIRCLE_JOB" == "PYTORCH" ]]; then
source venv/bin/activate
git clone https://github.com/pytorch/pytorch.git --recursive
cd pytorch
git checkout 7f86fb8995d9990fe1eac5a18335523cb3da7f09

This comment has been minimized.

Copy link
@rdzhabarov

rdzhabarov Aug 21, 2019

Contributor

I'm curious how did we get a build failure on a master if we have not updated pytorch sha before?

technically, as long as we pinned to a certain version of pytorch we should be fine build Glow and do not get spurious failures, but i might be missing something.

This comment has been minimized.

Copy link
@jackm321

jackm321 Aug 21, 2019

Author Contributor

Because the diff that caused this was a pytorch that changed tensor types in pytorch and in glow, there was a corresponding pytorch github pr but not a corresponding glow github pr so no way for failure to occur on master. I removed this sha here because basically the thought is that if glow is tracking pytorch master in fbcode it should be in open source also other wise this will happen. If anyone has alternative thoughts I'm open to it though.

This comment has been minimized.

Copy link
@rdzhabarov

rdzhabarov Aug 21, 2019

Contributor

Got it. I think this sounds good, it does not seem that build time increased a lot and anyway we track pytorch master in fbcode very close as you said.

@facebook-github-bot
Copy link

left a comment

@jackm321 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Aug 21, 2019

@jackm321 merged this pull request in 4f27105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.