Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resnet-runtime] Print the correct device type #3478

Conversation

@SplitInfinity
Copy link
Contributor

commented Aug 30, 2019

Description
This commit modifies resnet-runtime to print the correct device type in
its log messages. It currently prints CPU regardless of which backend
is specified on the command line.

Testing
Ran the executable on the Interpreter and CPU and observed the log
messages:

$ ../build_DEBUG/bin/resnet-runtime ../glow/tests/images/imagenet/ -backend=Interpreter
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0830 07:35:04.535593 318879168 resnet-runtime.cpp:130] Initializing 5 Interpreter devices on HostManager.
I0830 07:35:04.536674 318879168 resnet-runtime.cpp:78] Loading resnet50 model.

$ ../build_DEBUG/bin/resnet-runtime ../glow/tests/images/imagenet/ -backend=CPU
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0830 07:35:14.114750 161125824 resnet-runtime.cpp:130] Initializing 5 CPU devices on HostManager.
I0830 07:35:14.115845 161125824 resnet-runtime.cpp:78] Loading resnet50 model.

Fixes
This PR fixes #3471.

[resnet-runtime] Print the correct device type
Description:
This commit modifies resnet-runtime to print the correct device type in
its log messages. It currently prints "CPU" regardless of which backend
is specified on the command line.

Testing:
Ran the executable on the Interpreter and CPU and observed the log
messages.

@SplitInfinity SplitInfinity force-pushed the SplitInfinity:show-resnet-runtime-device-name branch from 85b68cf to 1450543 Aug 30, 2019

@jfix71
jfix71 approved these changes Aug 30, 2019
@facebook-github-bot
Copy link

left a comment

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Aug 31, 2019

@SplitInfinity merged this pull request in d3cf782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.