Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handroll make_unique impl for future-compat with LLVM #3566

Closed
wants to merge 1 commit into from

Conversation

@bwasti
Copy link
Contributor

bwasti commented Sep 27, 2019

Summary: Newer versions of LLVM (10+) will use C++14, eliding the need for make_unique.
This diff removes it entirely: https://reviews.llvm.org/D66259

Documentation: Updated docs/Tracing.md and all examples + core code with llvm::make_unique.

Test Plan: Build and run all tests

Copy link
Contributor

bertmaher left a comment

Thanks for doing this! At some point Glow should get with the program and assume C++14 :-p. Until then we'll make our own uniques, thankyouverymuch :-)

@bwasti bwasti force-pushed the bwasti:master branch from 79c76ae to 1e3e997 Oct 2, 2019
@bwasti

This comment has been minimized.

Copy link
Contributor Author

bwasti commented Oct 2, 2019

tests now pass :)

Copy link

facebook-github-bot left a comment

@opti-mix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@rdzhabarov

This comment has been minimized.

Copy link
Contributor

rdzhabarov commented Oct 17, 2019

@bwasti can you rebase and resolve conflicts. @bertmaher is OOO, I'll merge once it's updated.

@rdzhabarov rdzhabarov self-assigned this Oct 17, 2019
@stale

This comment has been minimized.

Copy link

stale bot commented Nov 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale_will_be_closed label Nov 1, 2019
@bertmaher

This comment has been minimized.

Copy link
Contributor

bertmaher commented Nov 5, 2019

I'm back! Sorry I should have merged this right when it was put up. As penance I can try doing the merge.

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Nov 6, 2019

@bertmaher merged this pull request in f299e9c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.