Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BatchedMatMulInst for backends that don't want to lower #3752

Closed
wants to merge 1 commit into from

Conversation

@nickgg
Copy link
Contributor

nickgg commented Nov 7, 2019

Summary: We generally lower BatchMatMulNode to a series of Reshape + MatMul + Concat, so we don't have an instruction for it. Adding one for a backend that doesn't benefit from that lowering.

Documentation: comments

Test Plan: ninja check (no backend uses this instruction)

@nickgg nickgg requested a review from SplitInfinity Nov 7, 2019
Copy link

facebook-github-bot left a comment

@nickgg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Nov 8, 2019

@nickgg merged this pull request in 297c8c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.