Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated notes on Ubuntu llvm versions #3769

Closed
wants to merge 2 commits into from
Closed

Conversation

@badenh
Copy link
Contributor

badenh commented Nov 10, 2019

Summary: updated notes on Ubuntu llvm version ship inclusions and requirements.

Documentation:

[Optional Fixes #issue]

Test Plan:

Please see a detailed explanation of how to fill out the fields in the relevant sections in PULL_REQUEST.md.

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Nov 10, 2019

Hi badenh! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

fixed #3741
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Nov 10, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale

This comment has been minimized.

Copy link

stale bot commented Nov 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@jfix71
jfix71 approved these changes Nov 25, 2019
Copy link
Contributor

jfix71 left a comment

Thanks for updating this @badenh!

@stale stale bot removed the stale_will_be_closed label Nov 25, 2019
Copy link

facebook-github-bot left a comment

@jfix71 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@stale

This comment has been minimized.

Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Dec 10, 2019

@jfix71 merged this pull request in fad7bc0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.