Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Add fb::embedding_bag_byte_rowwise_offsets #3792

Closed

Conversation

@jackm321
Copy link
Contributor

jackm321 commented Nov 18, 2019

Summary:

  • Add loader for fb::embedding_bag_byte_rowwise_offsets
  • Add EmbeddingBagByteRowwiseOffsetsNode similar to FusedRowwiseQuantizedSparseLengthsWeightedSum but with offsets instead of lengths

Documentation:
doxygen

Test Plan:
Added operator test
Not sure yet how to add a test for the loader

@jackm321 jackm321 requested review from yinghai, qizzzh and zrphercule Nov 18, 2019
@jackm321 jackm321 force-pushed the jackm321:embedding_bag_byte_rowwise_offsets branch 2 times, most recently from ae0d824 to e3594c7 Nov 18, 2019
Copy link
Contributor

yinghai left a comment

LGTM

@jackm321 jackm321 force-pushed the jackm321:embedding_bag_byte_rowwise_offsets branch from e3594c7 to 2ef2a0f Nov 19, 2019
Copy link

facebook-github-bot left a comment

@jackm321 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jackm321 jackm321 force-pushed the jackm321:embedding_bag_byte_rowwise_offsets branch 2 times, most recently from 174c3ac to e1b53d9 Nov 20, 2019
Copy link

facebook-github-bot left a comment

@jackm321 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jackm321 jackm321 force-pushed the jackm321:embedding_bag_byte_rowwise_offsets branch from e1b53d9 to 1413104 Nov 21, 2019
Copy link

facebook-github-bot left a comment

@jackm321 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.