Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCL] Implement LocalResponseNormalization{,Grad}Inst #3814

Closed

Conversation

@pjaaskel
Copy link
Contributor

pjaaskel commented Nov 23, 2019

Summary:

Implement LocalResponseNormalization{,Grad}Inst for OpenCL.

Documentation:

Trivial implementation: copied the interpreter version and converted the outer loops to work-items.

Fixes #3802

Test Plan:

Passes 'ninja check'.

@pjaaskel

This comment has been minimized.

Copy link
Contributor Author

pjaaskel commented Dec 7, 2019

Can I get this merged?

@pjaaskel pjaaskel force-pushed the parmance:opencl-localresponsenormalization branch from 3562ba8 to 9dd0d46 Dec 7, 2019
@pjaaskel

This comment has been minimized.

Copy link
Contributor Author

pjaaskel commented Dec 7, 2019

Removed a spurious debugging output and rebased.

@jfix71
jfix71 approved these changes Dec 18, 2019
Copy link
Contributor

jfix71 left a comment

LGTM

Copy link

facebook-github-bot left a comment

@jfix71 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Dec 19, 2019

@jfix71 merged this pull request in de133ee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.