Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch_glow] Add ability to pass backend specific options #4141

Closed

Conversation

@mneilly-et
Copy link
Contributor

mneilly-et commented Feb 10, 2020

Add ability to pass backend specific options to backends from torch_glow

Summary:

Host manager already provides the --load-backend-specific-options command
line option which loads a YAML file containing backend options. When using
torch_glow, it is currently not possible ot pass this option.

This change adds torch_glow.loadBackendSpecificOptions() which takes the name
of a YAML file. CachingGraphRunner will pass the name of the YAML file to the
host manager via cctx.backendOpts.backendSpecificOpts and host manager will
load the options into the context which is already passed to backends.

Fixes: #4140

@mneilly-et mneilly-et force-pushed the mneilly-et:torch-glow-backend-options branch 2 times, most recently from c950cf5 to d54ed03 Feb 10, 2020
@mneilly-et mneilly-et requested a review from jackm321 Feb 12, 2020
@mneilly-et mneilly-et force-pushed the mneilly-et:torch-glow-backend-options branch from d54ed03 to 61edd1f Feb 20, 2020
…low.

Summary:

Host manager already provides the --load-backend-specific-options command
line option which loads a YAML file containing backend options. When using
torch_glow, it is currently not possible ot pass this option.

This change adds torch_glow.loadBackendSpecificOptions() which takes the name
of a YAML file. CachingGraphRunner will pass the name of the YAML file to the
host manager via cctx.backendOpts.backendSpecificOpts and host manager will
load the options into the context which is already passed to backends.
@mneilly-et mneilly-et force-pushed the mneilly-et:torch-glow-backend-options branch from 61edd1f to 888cf90 Mar 2, 2020
Copy link

facebook-github-bot left a comment

@jackm321 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mneilly-et

This comment has been minimized.

Copy link
Contributor Author

mneilly-et commented Mar 21, 2020

I was going to bring this current with master but saw the "@jackm321 has imported this pull request." message and wasn't sure at that point. Should I go ahead and update the PR?

@jackm321

This comment has been minimized.

Copy link
Contributor

jackm321 commented Mar 23, 2020

@mneilly-et, I can rebase it

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Mar 26, 2020

@jackm321 merged this pull request in 78e43cb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.