Skip to content

Conversation

@yf225
Copy link
Contributor

@yf225 yf225 commented Nov 11, 2025

Remove @helion.jit usage in codebase, but keeping it for BC.

@yf225 yf225 requested review from jansel and oulgen November 11, 2025 22:14
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 11, 2025
@yf225 yf225 changed the title Remove @helion.jit and advise use of @helion.kernel Remove @helion.jit and advise use of @helion.kernel Nov 11, 2025
Copy link
Contributor

@oulgen oulgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

til

"Settings",
"cdiv",
"exc",
"jit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break BC. Is there any harm in keeping it? Seems like a common typo (since other langs like triton/jax use jit).

(We should change all the usages though.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great I will keep it for BC

@yf225 yf225 changed the title Remove @helion.jit and advise use of @helion.kernel Remove @helion.jit usage and advise use of @helion.kernel Nov 12, 2025
@yf225 yf225 merged commit 51580b4 into main Nov 12, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants