From c354a8e13916c2d43c041eb8366b1ccf621fd0ab Mon Sep 17 00:00:00 2001 From: Benjamin Kinga Date: Mon, 5 Oct 2020 16:37:44 -0500 Subject: [PATCH 1/3] added tuple type to mixins.py --- ignite/base/mixins.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ignite/base/mixins.py b/ignite/base/mixins.py index 5cb35e1712fc..7d2e17a9c2a5 100644 --- a/ignite/base/mixins.py +++ b/ignite/base/mixins.py @@ -4,8 +4,8 @@ class Serializable: - _state_dict_all_req_keys = () - _state_dict_one_of_opt_keys = () + _state_dict_all_req_keys = () # type: tuple + _state_dict_one_of_opt_keys = () # type: tuple def state_dict(self) -> OrderedDict: pass From 28dcbd99892ac9154c62b926894f4bbb48f97367 Mon Sep 17 00:00:00 2001 From: Benjamin Kinga Date: Mon, 5 Oct 2020 16:56:24 -0500 Subject: [PATCH 2/3] allow mypy to pass through base file --- mypy.ini | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mypy.ini b/mypy.ini index 586ae4633cf3..e0372c8029f2 100644 --- a/mypy.ini +++ b/mypy.ini @@ -3,10 +3,6 @@ files = ignite pretty = True show_error_codes = True -[mypy-ignite.base.*] - -ignore_errors = True - [mypy-ignite.contrib.*] ignore_errors = True From 776542e6ce0e6bb9076330b99fba91848d0096c1 Mon Sep 17 00:00:00 2001 From: Benjamin Kinga Date: Mon, 5 Oct 2020 17:55:12 -0500 Subject: [PATCH 3/3] fixed linting issues --- ignite/base/mixins.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ignite/base/mixins.py b/ignite/base/mixins.py index 7d2e17a9c2a5..93b3ac0dd424 100644 --- a/ignite/base/mixins.py +++ b/ignite/base/mixins.py @@ -4,8 +4,8 @@ class Serializable: - _state_dict_all_req_keys = () # type: tuple - _state_dict_one_of_opt_keys = () # type: tuple + _state_dict_all_req_keys = () # type: tuple + _state_dict_one_of_opt_keys = () # type: tuple def state_dict(self) -> OrderedDict: pass