Fix CUPTI Range Profiler test #1091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Simple fix that was causing a test failure earlier. The test mocks the object but the destructor calls CUDA deinit() API. This should have been fused out basically. https://github.com/pytorch/kineto/blob/main/libkineto/src/CuptiRangeProfilerApi.cpp#L716-L719 Differential Revision: D75494874
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75494874 |
Contributor
|
This pull request has been merged in 3a37788. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #949
Simple fix that was causing a test failure earlier. The test mocks the object but the destructor calls CUDA deinit() API. This should have been fused out basically.
https://github.com/pytorch/kineto/blob/main/libkineto/src/CuptiRangeProfilerApi.cpp#L716-L719
Differential Revision: D75494874