Get rid of fmt::localtime #1092
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75563129 |
ngimel
approved these changes
May 28, 2025
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
May 28, 2025
Summary: fmt::localtime is deprecated. Use std for better compatability Reviewed By: ngimel Differential Revision: D75563129
sraikund16
force-pushed
the
export-D75563129
branch
from
6e57cbb to
7b38713
Compare
sraikund16
added a commit
to sraikund16/kineto
that referenced
this pull request
May 28, 2025
Summary: fmt::localtime is deprecated. Use std for better compatability Reviewed By: ngimel Differential Revision: D75563129
sraikund16
force-pushed
the
export-D75563129
branch
from
7b38713 to
0dda60b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75563129 |
malfet
approved these changes
May 28, 2025
Summary: Pull Request resolved: pytorch#1092 fmt::localtime is deprecated. Use std for better compatability Reviewed By: malfet, ngimel Differential Revision: D75563129
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75563129 |
sraikund16
force-pushed
the
export-D75563129
branch
from
0dda60b to
a4c6354
Compare
Contributor
|
This pull request has been merged in be90296. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: fmt::localtime is deprecated. Use std for better compatability
Differential Revision: D75563129