From 517ffe6bddc096da1228e9304e999384068bb372 Mon Sep 17 00:00:00 2001 From: Ilia Cherniavskii Date: Mon, 19 Apr 2021 19:47:42 -0700 Subject: [PATCH] Fix OSS compilation error Summary: In OSS not all builds support nodiscard https://app.circleci.com/pipelines/github/pytorch/pytorch/305130/workflows/1885277b-9d54-4637-ab9f-7234be2f2ee2/jobs/12588162 Reviewed By: dzhulgakov Differential Revision: D27872203 fbshipit-source-id: 9c95654baac410f56aa2080711e22f45ce034c68 --- libkineto/include/ClientTraceActivity.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libkineto/include/ClientTraceActivity.h b/libkineto/include/ClientTraceActivity.h index d98156f35..79fe4597b 100644 --- a/libkineto/include/ClientTraceActivity.h +++ b/libkineto/include/ClientTraceActivity.h @@ -64,7 +64,7 @@ struct ClientTraceActivity : TraceActivity { metadata_.push_back(std::move(kv)); } - [[nodiscard]] const std::string getMetadata() const { + const std::string getMetadata() const { return fmt::format("{}", fmt::join(metadata_, ", ")); }