Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_jit_fuser_te not testing failures properly due to unexpected implicit string concatenation #70607

Closed
code-review-doctor opened this issue Jan 4, 2022 · 1 comment
Assignees
Labels
oncall: jit Add this issue/PR to JIT oncall triage queue
Projects

Comments

@code-review-doctor
Copy link
Contributor

馃悰 Describe the bug

A comma is missing from line 2093

known_failures = [
'__rmatmul__'
'frac',
'matmul',
]

This results in '__rmatmul__' and 'frac' being concatenated together to form '__rmatmul__frac'

so the list evaluates to two items instead of three: ['__rmatmul__frac', 'matmul']

The impact of this missing comma is test_failures and test_failures will not be testing __rmatmul__ and frac:

@ops([op for op in op_db if get_name(op) in known_failures], allowed_dtypes=(torch.float,))

@ops([op for op in op_db if get_name(op) not in works_list + known_failures], allowed_dtypes=(torch.float,))

The fix is of course to add the comma like so:

 known_failures = [ 
     '__rmatmul__' ,
     'frac', 
     'matmul', 
 ] 

I can raise a PR for this?

Versions

NA

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jan 4, 2022
@github-actions github-actions bot added this to Need triage in JIT Triage Jan 4, 2022
@davidberard98
Copy link
Contributor

@code-review-doctor it would be great if you had a PR for this!

@davidberard98 davidberard98 self-assigned this Jan 21, 2022
JIT Triage automation moved this from Need triage to Done Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
JIT Triage
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants