We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
A comma is missing from line 2093
pytorch/test/test_jit_fuser_te.py
Lines 2092 to 2096 in 1b66915
This results in '__rmatmul__' and 'frac' being concatenated together to form '__rmatmul__frac'
'__rmatmul__'
'frac'
'__rmatmul__frac'
so the list evaluates to two items instead of three: ['__rmatmul__frac', 'matmul']
['__rmatmul__frac', 'matmul']
The impact of this missing comma is test_failures and test_failures will not be testing __rmatmul__ and frac:
test_failures
__rmatmul__
frac
Line 2159 in 1b66915
Line 2170 in 1b66915
The fix is of course to add the comma like so:
known_failures = [ '__rmatmul__' , 'frac', 'matmul', ]
I can raise a PR for this?
NA
The text was updated successfully, but these errors were encountered:
@code-review-doctor it would be great if you had a PR for this!
Sorry, something went wrong.
davidberard98
Successfully merging a pull request may close this issue.
馃悰 Describe the bug
A comma is missing from line 2093
pytorch/test/test_jit_fuser_te.py
Lines 2092 to 2096 in 1b66915
This results in
'__rmatmul__'and'frac'being concatenated together to form'__rmatmul__frac'so the list evaluates to two items instead of three:
['__rmatmul__frac', 'matmul']The impact of this missing comma is
test_failuresandtest_failureswill not be testing__rmatmul__andfrac:pytorch/test/test_jit_fuser_te.py
Line 2159 in 1b66915
pytorch/test/test_jit_fuser_te.py
Line 2170 in 1b66915
The fix is of course to add the comma like so:
I can raise a PR for this?
Versions
NA
The text was updated successfully, but these errors were encountered: