[activation checkpointing] Tagging based min cut partitioner #103357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/103357
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0389cb4: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
anijain2305
added a commit
that referenced
this pull request
Jun 9, 2023
ghstack-source-id: 7460f23e423c619aa2ffe8ccab9978e079d8b774 Pull Request resolved: #103357
anijain2305
commented
Jun 9, 2023
[ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Jun 10, 2023
ghstack-source-id: 6fde7c1ac9b9c62a01de3365b9bb7642e5960b6d Pull Request resolved: #103357
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Jun 10, 2023
ghstack-source-id: 2f5a570a37920788eb54ce4fe5bad7e7aaabe4ba Pull Request resolved: #103357
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Jun 10, 2023
ghstack-source-id: de40da68dd7d58a37196a87da22cbe53d17dd3f0 Pull Request resolved: #103357
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Jun 10, 2023
ghstack-source-id: 1ba53e37a1b1e75961b9e1e33d7039a3131dd92c Pull Request resolved: #103357
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Jun 10, 2023
ghstack-source-id: f12499283b88fc044d7fc066c3393c4d5f290984 Pull Request resolved: #103357
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Jun 10, 2023
ghstack-source-id: deeea3f322e7cf77214da6c684dbe034334c63eb Pull Request resolved: #103357
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Jun 10, 2023
ghstack-source-id: 1865b1a06ba776793c28860d8c139b0ab993a804 Pull Request resolved: #103357
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
anijain2305
changed the title
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
jansel
approved these changes
Jun 14, 2023
torch/_functorch/partitioners.py
Outdated
| @@ -26,6 +26,21 @@ def is_symint_node(node): | |||
| assert hasattr(node, 'meta'), "All nodes traced with proxy_tensor should have meta" | |||
| return "val" in node.meta and isinstance(node.meta['val'], torch.SymInt) | |||
|
|
|||
| def must_recompute(node): | |||
| return "recompute" in node.meta and node.meta["recompute"] | |||
There was a problem hiding this comment.
Suggested change
| return "recompute" in node.meta and node.meta["recompute"] | |
| return node.meta.get("recompute", False) |
| for output in output_node.args[0]: | ||
| if isinstance(output, torch.fx.node.Node): | ||
| if output not in env: | ||
| print("output gradient dependent only on fwd", output) |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy aakhundov [ghstack-poisoned]
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @msaroufim @aakhundov