Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inference_mode decorator pass mode as kwarg #107349

Closed
wants to merge 1 commit into from
Closed

Fix inference_mode decorator pass mode as kwarg #107349

wants to merge 1 commit into from

Conversation

soulitzer
Copy link
Contributor

@soulitzer soulitzer commented Aug 17, 2023 •
edited
Loading

@soulitzer soulitzer requested a review from albanD as a code owner August 17, 2023 02:31
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 17, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107349

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0efaa78 with merge base 3577ae3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

soulitzer added a commit that referenced this pull request Aug 17, 2023
@soulitzer
Fix inference_mode decorator pass mode as kwarg
6d6758e 
ghstack-source-id: c5cd230a318d1b9c62cdaedc51f61141a69ea8bc
Pull Request resolved: #107349
albanD
albanD approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 17, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 17, 2023

+1

@albanD albanD added the topic: not user facing topic category label Aug 17, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Comment with id 1582555477 not found

Details for Dev Infra team Raised by workflow job

@albanD
Copy link
Collaborator

albanD commented Aug 17, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda12_1-with-pypi-cudnn-test / test

Details for Dev Infra team Raised by workflow job

@albanD
Copy link
Collaborator

albanD commented Aug 17, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: linux-binary-manywheel / manywheel-py3_8-cuda12_1-with-pypi-cudnn-test / test

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/soulitzer/226/head branch August 21, 2023 14:17
@soulitzer soulitzer mentioned this pull request Aug 31, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 11, 2023
@soulitzer @pytorchmergebot
Update CopySlices to not internal assert when grad_output is undefined (
3efc188 
#108353)

Fixes #107928

Pull Request resolved: #108353
Approved by: https://github.com/albanD
ghstack dependencies: #107296, #107349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soulitzer @pytorchmergebot @albanD