Skip to content

[PyTorch] remove branch in isIntrusivePtr#109273

Closed
swolchok wants to merge 3 commits intogh/swolchok/577/basefrom
gh/swolchok/577/head
Closed

[PyTorch] remove branch in isIntrusivePtr#109273
swolchok wants to merge 3 commits intogh/swolchok/577/basefrom
gh/swolchok/577/head

Conversation

@swolchok
Copy link
Copy Markdown
Contributor

@swolchok swolchok commented Sep 14, 2023

Stack from ghstack (oldest at bottom):

There is a code comment in ivalue.h that is intended to explain the motivation for this change fully; please request changes if it doesn't.

Differential Revision: D49245910

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

There is a code comment in ivalue.h that is intended to explain the motivation for this change fully; please request changes if it doesn't.

Differential Revision: [D49245910](https://our.internmc.facebook.com/intern/diff/D49245910/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D49245910/)!

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Sep 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109273

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6b61e14 with merge base f22b303 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Sep 14, 2023
There is a code comment in ivalue.h that is intended to explain the motivation for this change fully; please request changes if it doesn't.

Differential Revision: [D49245910](https://our.internmc.facebook.com/intern/diff/D49245910/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D49245910/)!

ghstack-source-id: 200681992
Pull Request resolved: #109273
@swolchok swolchok requested review from ezyang and malfet September 14, 2023 03:52
@swolchok
Copy link
Copy Markdown
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

There is a code comment in ivalue.h that is intended to explain the motivation for this change fully; please request changes if it doesn't.

Differential Revision: [D49245910](https://our.internmc.facebook.com/intern/diff/D49245910/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D49245910/)!

[ghstack-poisoned]
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Successfully rebased gh/swolchok/577/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/109273)

pytorchmergebot pushed a commit that referenced this pull request Sep 14, 2023
There is a code comment in ivalue.h that is intended to explain the motivation for this change fully; please request changes if it doesn't.

Differential Revision: [D49245910](https://our.internmc.facebook.com/intern/diff/D49245910/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D49245910/)!

ghstack-source-id: d057e44
Pull Request resolved: #109273
@swolchok
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 14, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

There is a code comment in ivalue.h that is intended to explain the motivation for this change fully; please request changes if it doesn't.

Differential Revision: [D49245910](https://our.internmc.facebook.com/intern/diff/D49245910/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D49245910/)!

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 18, 2023
Pull Request resolved: #109273

There is a code comment in ivalue.h that is intended to explain the motivation for this change fully; please request changes if it doesn't.

Differential Revision: [D49245910](https://our.internmc.facebook.com/intern/diff/D49245910/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D49245910/)!
ghstack-source-id: 201099747
@swolchok
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@swolchok
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/577/head branch September 23, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants