Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
nn.Module hook fix and improvements #12573
This PR adds the following:
Do we actually want to check the returned values from the forward hooks?
Adding support for Module taking other things than Tensors (and giving
2 times, most recently
Oct 11, 2018
referenced this pull request
Oct 13, 2018
@ezyang it seems that CircleCI has history of it (https://circleci.com/gh/pytorch/workflows/pytorch/tree/pull%2F12573), but the statuses don't show up here. I just submitted a ticket to CircleCI.
left a comment
I have some suggestions for improvements, but the PR generally looks ok. It's definitely a step in a good direction compared to the fully broken behavior we have today, but I'm worried that it might still fail in cases like this one (that's related to resetting of
This strategy is promising but cause a lot of problems if inputs or outputs are modified inplace. In particular, hooks are not called anymore.