Skip to content

deprecated datetime.utcnow() fix and _RendezvousJoinOp module initiation bug fix#136141

Closed
AminAlam wants to merge 12 commits intopytorch:mainfrom
AminAlam:main
Closed

deprecated datetime.utcnow() fix and _RendezvousJoinOp module initiation bug fix#136141
AminAlam wants to merge 12 commits intopytorch:mainfrom
AminAlam:main

Conversation

@AminAlam
Copy link
Copy Markdown
Contributor

@AminAlam AminAlam commented Sep 16, 2024 •
edited by pytorch-bot bot
Loading

@AminAlam AminAlam requested a review from a team as a code owner September 16, 2024 13:19
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Sep 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136141

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 556e8a8 with merge base 52c917b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Sep 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (torchelastic) labels Sep 16, 2024
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 16, 2024
@janeyx99 janeyx99 requested review from a team, kwen2501 and wdvr and removed request for a team September 16, 2024 16:11
@XilunWu XilunWu added the python Pull requests that update Python code label Sep 19, 2024
@XilunWu
Copy link
Copy Markdown
Contributor

XilunWu commented Sep 19, 2024

LGTM. One thing to note is the below files also contain datetime.utcfromtimestamp:
torch/fb/fx/graph_logger.py
benchmarks/operator_benchmark/fb/fetch_ops.py

@XilunWu XilunWu requested review from albanD and d4l3k September 19, 2024 00:25
@XilunWu XilunWu mentioned this pull request Sep 19, 2024
Closed
kwen2501
kwen2501 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If CI is happy, please go ahead and land it.

@AminAlam
Redundant cast removed
e6515ac 
As type of state.deadline is always datetime.datetime (if not None), the cast to datetime.datetime was redundant and therefore removed
@AminAlam
unused cast import removed
c798823
@kwen2501
Copy link
Copy Markdown
Collaborator

kwen2501 commented Sep 22, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 22, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 22, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 22, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@albanD albanD removed their request for review September 23, 2024 19:31
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 24, 2024

Merge failed

Reason: Comment with id 2370374146 not found

Details for Dev Infra team Raised by workflow job

@AminAlam
Copy link
Copy Markdown
Contributor Author

AminAlam commented Sep 24, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@AminAlam @BoyuanFeng
deprecated datetime.utcnow() fix and _RendezvousJoinOp module initiat…
9d2b1aa 
…ion bug fix (pytorch#136141)

Fix to pytorch#136140

Pull Request resolved: pytorch#136141
Approved by: https://github.com/kwen2501
This was referenced Nov 17, 2025
Closed
Open
@guangyey guangyey mentioned this pull request Dec 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@wdvr wdvr Awaiting requested review from wdvr

@d4l3k d4l3k Awaiting requested review from d4l3k

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source python Pull requests that update Python code release notes: distributed (torchelastic) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AminAlam @XilunWu @kwen2501 @pytorchmergebot @pytorchbot @janeyx99