Skip to content

[FlexAttention] Rename zeros_and_scatter library #141185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Nov 20, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141185

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 87e20be with merge base 2ee2dcb (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

  • linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test (gh) (similar failure)
    RuntimeError: cuDNN version incompatibility: PyTorch was compiled against (9, 5, 1) but found runtime version (9, 1, 0). PyTorch already comes bundled with cuDNN. One option to resolving this error is to ensure PyTorch can find the bundled cuDNN. one possibility is that there is a conflicting cuDNN in LD_LIBRARY_PATH.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
@drisspg
Copy link
Contributor Author

drisspg commented Nov 21, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 22, 2024
# Summary
### Before
```Shell
48.71s call     test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager
```
### After
Speeds up grad check tests by 10x
```Shell
4.74s call     test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager
```

Pull Request resolved: #141356
Approved by: https://github.com/BoyuanFeng
ghstack dependencies: #141164, #141185
youssef62 pushed a commit to youssef62/pytorch that referenced this pull request Nov 23, 2024
# Summary
Previous custom op library name was a little verbose and didn't really align with how we typically name our libraries.

Pull Request resolved: pytorch#141185
Approved by: https://github.com/Chillee
ghstack dependencies: pytorch#141164
youssef62 pushed a commit to youssef62/pytorch that referenced this pull request Nov 23, 2024
# Summary
### Before
```Shell
48.71s call     test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager
```
### After
Speeds up grad check tests by 10x
```Shell
4.74s call     test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager
```

Pull Request resolved: pytorch#141356
Approved by: https://github.com/BoyuanFeng
ghstack dependencies: pytorch#141164, pytorch#141185
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
# Summary
Previous custom op library name was a little verbose and didn't really align with how we typically name our libraries.

Pull Request resolved: pytorch#141185
Approved by: https://github.com/Chillee
ghstack dependencies: pytorch#141164
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
# Summary
### Before
```Shell
48.71s call     test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager
```
### After
Speeds up grad check tests by 10x
```Shell
4.74s call     test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager
```

Pull Request resolved: pytorch#141356
Approved by: https://github.com/BoyuanFeng
ghstack dependencies: pytorch#141164, pytorch#141185
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
# Summary
Previous custom op library name was a little verbose and didn't really align with how we typically name our libraries.

Pull Request resolved: pytorch#141185
Approved by: https://github.com/Chillee
ghstack dependencies: pytorch#141164
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
# Summary
### Before
```Shell
48.71s call     test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager
```
### After
Speeds up grad check tests by 10x
```Shell
4.74s call     test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager
```

Pull Request resolved: pytorch#141356
Approved by: https://github.com/BoyuanFeng
ghstack dependencies: pytorch#141164, pytorch#141185
@github-actions github-actions bot deleted the gh/drisspg/84/head branch December 22, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants