-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[FlexAttention] Rename zeros_and_scatter library #141185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141185
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 87e20be with merge base 2ee2dcb ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
# Summary ### Before ```Shell 48.71s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` ### After Speeds up grad check tests by 10x ```Shell 4.74s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` Pull Request resolved: #141356 Approved by: https://github.com/BoyuanFeng ghstack dependencies: #141164, #141185
# Summary Previous custom op library name was a little verbose and didn't really align with how we typically name our libraries. Pull Request resolved: pytorch#141185 Approved by: https://github.com/Chillee ghstack dependencies: pytorch#141164
# Summary ### Before ```Shell 48.71s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` ### After Speeds up grad check tests by 10x ```Shell 4.74s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` Pull Request resolved: pytorch#141356 Approved by: https://github.com/BoyuanFeng ghstack dependencies: pytorch#141164, pytorch#141185
# Summary Previous custom op library name was a little verbose and didn't really align with how we typically name our libraries. Pull Request resolved: pytorch#141185 Approved by: https://github.com/Chillee ghstack dependencies: pytorch#141164
# Summary ### Before ```Shell 48.71s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` ### After Speeds up grad check tests by 10x ```Shell 4.74s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` Pull Request resolved: pytorch#141356 Approved by: https://github.com/BoyuanFeng ghstack dependencies: pytorch#141164, pytorch#141185
# Summary Previous custom op library name was a little verbose and didn't really align with how we typically name our libraries. Pull Request resolved: pytorch#141185 Approved by: https://github.com/Chillee ghstack dependencies: pytorch#141164
# Summary ### Before ```Shell 48.71s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` ### After Speeds up grad check tests by 10x ```Shell 4.74s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` Pull Request resolved: pytorch#141356 Approved by: https://github.com/BoyuanFeng ghstack dependencies: pytorch#141164, pytorch#141185
Stack from ghstack (oldest at bottom):
Summary
Previous custom op library name was a little verbose and didn't really align with how we typically name our libraries.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov