Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: fix NCCL install #14172

Closed
wants to merge 2 commits into from
Closed

Conversation

yf225
Copy link
Contributor

@yf225 yf225 commented Nov 18, 2018

The $BUILD_ENVIRONMENT checks work in test.sh but not build.sh, this PR fixes the issue.

This replaces #14124.

@yf225 yf225 requested a review from teng-li November 18, 2018 21:03
@yf225
Copy link
Contributor Author

yf225 commented Nov 18, 2018

@teng-li Should we fix this error in pytorch_linux_trusty_py2_7_9_build:

Nov 18 21:13:50 /var/lib/jenkins/workspace/torch/lib/c10d/ProcessGroupMPI.cpp: In destructor 'virtual c10d::ProcessGroupMPI::AsyncWork::~AsyncWork()':
Nov 18 21:13:50 /var/lib/jenkins/workspace/torch/lib/c10d/ProcessGroupMPI.cpp:154:71: error: throw will always call terminate() [-Werror=terminate]
Nov 18 21:13:50          "Attempted destruction of AsyncWork before work has completed");
Nov 18 21:13:50                                                                        ^
Nov 18 21:13:50 /var/lib/jenkins/workspace/torch/lib/c10d/ProcessGroupMPI.cpp:154:71: note: in C++11 destructors default to noexcept

@teng-li
Copy link
Contributor

teng-li commented Nov 19, 2018

@yf225 this has been fixed

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants