[OpenReg] Add poison fork check for OpenReg #165728
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165728
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 2592d5e with merge base 4295a9a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
fffrog
added a commit
that referenced
this pull request
Oct 17, 2025
**Background**: ```bash pytest -s tests/test_autocast.py -vv tests/test_autocast.py::TestAutocastoOpenReg::test_openreg_autocast_float16_supported /home/coder/code/pytorch/torch/_dynamo/eval_frame.py:1037: UserWarning: Set seed for `openreg` device does not take effect, please add API's `_is_in_bad_fork` and `manual_seed_all` to `openreg` device module. ``` Therefore, we need to add `_is_in_bad_fork` to OpenReg. In addition, the OpenReg backend uses the CPU to simulate multi-threaded implementations of Stream and Event, so fork prevention is indeed necessary after initialization. ghstack-source-id: 1e6a255 Pull-Request: #165728
38 tasks
albanD
reviewed
Oct 17, 2025
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Sounds great!
Tests and a couple lines in the user guide about this would be great.
Collaborator
Author
Thank you for helpful comments. I will add tests for this changes right now, and the docs will be added in the later PR that are developed by other contributors. |
fffrog
added a commit
that referenced
this pull request
Oct 26, 2025
**Background**: ```bash pytest -s tests/test_autocast.py -vv tests/test_autocast.py::TestAutocastoOpenReg::test_openreg_autocast_float16_supported /home/coder/code/pytorch/torch/_dynamo/eval_frame.py:1037: UserWarning: Set seed for `openreg` device does not take effect, please add API's `_is_in_bad_fork` and `manual_seed_all` to `openreg` device module. ``` Therefore, we need to add `_is_in_bad_fork` to OpenReg. In addition, the OpenReg backend uses the CPU to simulate multi-threaded implementations of Stream and Event, so fork prevention is indeed necessary after initialization. ghstack-source-id: 0413a98 Pull-Request: #165728
fffrog
added a commit
that referenced
this pull request
Oct 26, 2025
**Background**: ```bash pytest -s tests/test_autocast.py -vv tests/test_autocast.py::TestAutocastoOpenReg::test_openreg_autocast_float16_supported /home/coder/code/pytorch/torch/_dynamo/eval_frame.py:1037: UserWarning: Set seed for `openreg` device does not take effect, please add API's `_is_in_bad_fork` and `manual_seed_all` to `openreg` device module. ``` Therefore, we need to add `_is_in_bad_fork` to OpenReg. In addition, the OpenReg backend uses the CPU to simulate multi-threaded implementations of Stream and Event, so fork prevention is indeed necessary after initialization. ghstack-source-id: bd85439 Pull-Request: #165728
Collaborator
Author
Hey @albanD, so sorry for the late commit I have added test case related posion fork, please take a look at it. Thank you. |
Collaborator
Author
|
#166256, which can lead to something wrong for |
fffrog
added a commit
that referenced
this pull request
Oct 26, 2025
**Background**: ```bash pytest -s tests/test_autocast.py -vv tests/test_autocast.py::TestAutocastoOpenReg::test_openreg_autocast_float16_supported /home/coder/code/pytorch/torch/_dynamo/eval_frame.py:1037: UserWarning: Set seed for `openreg` device does not take effect, please add API's `_is_in_bad_fork` and `manual_seed_all` to `openreg` device module. ``` Therefore, we need to add `_is_in_bad_fork` to OpenReg. In addition, the OpenReg backend uses the CPU to simulate multi-threaded implementations of Stream and Event, so fork prevention is indeed necessary after initialization. ghstack-source-id: d6b5e37 Pull-Request: #165728
fffrog
added a commit
that referenced
this pull request
Oct 27, 2025
**Background**: ```bash pytest -s tests/test_autocast.py -vv tests/test_autocast.py::TestAutocastoOpenReg::test_openreg_autocast_float16_supported /home/coder/code/pytorch/torch/_dynamo/eval_frame.py:1037: UserWarning: Set seed for `openreg` device does not take effect, please add API's `_is_in_bad_fork` and `manual_seed_all` to `openreg` device module. ``` Therefore, we need to add `_is_in_bad_fork` to OpenReg. In addition, the OpenReg backend uses the CPU to simulate multi-threaded implementations of Stream and Event, so fork prevention is indeed necessary after initialization. ghstack-source-id: 3dba2dd Pull-Request: #165728
ezyang
approved these changes
Oct 30, 2025
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Background:
Therefore, we need to add
_is_in_bad_forkto OpenReg.In addition, the OpenReg backend uses the CPU to simulate multi-threaded implementations of Stream and Event, so fork prevention is indeed necessary after initialization.