[easy][dynamo][pytree] simplify pytree polyfill module by move out the guard-if #167221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167221
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0e70774 with merge base ed4aa44 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 6, 2025
…e guard-if ghstack-source-id: 0cfe90c Pull-Request: pytorch#167221
XuehaiPan
added
topic: not user facing
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 6, 2025
…e guard-if ghstack-source-id: 0cfe90c Pull-Request: pytorch#167221
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 6, 2025
…e guard-if ghstack-source-id: 0cfe90c Pull-Request: pytorch#167221
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 7, 2025
…e guard-if ghstack-source-id: 0cfe90c Pull-Request: pytorch#167221
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 7, 2025
…e guard-if ghstack-source-id: 0cfe90c Pull-Request: pytorch#167221
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 7, 2025
…e guard-if ghstack-source-id: 0cfe90c Pull-Request: pytorch#167221
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 7, 2025
…e guard-if ghstack-source-id: 0cfe90c Pull-Request: pytorch#167221
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 7, 2025
…e guard-if ghstack-source-id: 0cfe90c Pull-Request: pytorch#167221
Lucaskabela
approved these changes
Nov 7, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 7, 2025
…e guard-if ghstack-source-id: 0cfe90c Pull-Request: pytorch#167221
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 7, 2025
Pull Request resolved: #167211 Approved by: https://github.com/Lucaskabela ghstack dependencies: #167221
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 7, 2025
…rlying CXX functions directly (#167292) Pull Request resolved: #167292 Approved by: https://github.com/Lucaskabela ghstack dependencies: #167221, #167211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the guard-if in
polyfills.pytreetopolyfills.loaderand dedent the code in the if-branch.Stack from ghstack (oldest at bottom):
tree_*functions accept both Python and C++PyTreeSpec#152624optreefunctions by polyfill the underlying CXX functions directly #167292cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela