Skip to content

[MPS] Add Metal complex mm implementation #167755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MPS] Add Metal complex mm implementation #167755

wants to merge 2 commits into from
+22 −1

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Nov 13, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

As MPSGraph one returns incorrect results if matrix inner dimention exceed 4K
Add regression test

Fixes #167727

@malfet
Update
c69e57f 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner November 13, 2025 19:59
@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Nov 13, 2025
malfet added a commit that referenced this pull request Nov 13, 2025
@malfet
[MPS] Add Metal complex mm implementation
06aca9d 
As MPSGraph one returns incorrect results if matrix inner dimention exceed 4K
Add regression test

Fixes #167727


ghstack-source-id: 4f83d02
Pull-Request: #167755
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167755

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a8ffb59 with merge base ae71b0e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added the topic: bug fixes topic category label Nov 13, 2025
Isalia20
Isalia20 reviewed Nov 13, 2025
View reviewed changes
@malfet malfet requested a review from dcci November 13, 2025 20:09
@malfet
Update
a8ffb59 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Nov 13, 2025
@malfet
[MPS] Add Metal complex mm implementation
c21f7c7 
As MPSGraph one returns incorrect results if matrix inner dimention exceed 4K
Add regression test

Fixes #167727

ghstack-source-id: d76af00
Pull-Request: #167755
@malfet
Copy link
Contributor Author

malfet commented Nov 13, 2025

@pytorchbot merge -f "LInt + MPS are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 13, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@dcci dcci Awaiting requested review from dcci

+1 more reviewer

@Isalia20 Isalia20 Isalia20 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @manuelcandales @Isalia20