Add batched version of trtrs #18025
Closed
Add batched version of trtrs #18025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwakftw
force-pushed
the
trtrs-batched
branch
from
156e143
to
e3421eb
Compare
- Remove single batch TH/THC implementations
vishwakftw
force-pushed
the
trtrs-batched
branch
from
e3421eb
to
645c07c
Compare
Seems like you don't need a magma_queue_t object
vishwakftw
changed the title
vishwakftw
added
the
ready for review (this tag is deprecated)
vishwakftw
force-pushed
the
trtrs-batched
branch
from
c9baeb2
to
33ed8fa
Compare
ifedan
reviewed
Mar 15, 2019
| result = at::_cholesky_solve_helper(self, A, upper); | ||
| Tensor result_tmp; | ||
| result_tmp = at::_cholesky_solve_helper(self, A, upper); | ||
| result.resize_as_(result_tmp).copy_(result_tmp); | ||
| return result; |
ifedan
reviewed
Mar 15, 2019
|
@pytorchbot retest this please |
|
@ifedan Is this good to go? |
|
ifedan
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
@ifedan is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@ifedan is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Mar 20, 2019
Summary: - Remove single batch TH/THC implementations - Remove `_batch_trtrs_lower` from `multivariate_normal` - Add tests for batched behavior - Modify trtrs_backward to accommodate for batched case - Modify docs In a future PR, this will be renamed to `triangular_solve`. Pull Request resolved: pytorch/pytorch#18025 Differential Revision: D14523004 Pulled By: ifedan fbshipit-source-id: 11c6a967d107f969b60e5a5c73ce6bb8099ebbe1
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_batch_trtrs_lowerfrommultivariate_normalIn a future PR, this will be renamed to
triangular_solve.