Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow static inheritence for ScriptModules #20503
Conversation
Summary: Previously, we registered script modules of parent classes during their init methods, making it impossible to correctly 'override' a method or leave it blank in a subclass. This diff adds the functionality by waiting until the child init is finished before registering all the methods. Test Plan: python test/test_jit.py
|
Looks good! Could you add a test for a module inheritance hierarchy of 3 ? It's not clear to me that we're currently iterating through bases in the right order, since the current test only has a single base. |
test/test_jit.py
Outdated
| v = torch.rand(3, 4) | ||
| b = B() | ||
| self.assertEqual(b(v), v + v * v) | ||
| >>>>>>> Allow static inheritence for ScriptModules |
This comment has been minimized.
This comment has been minimized.
Merged
This comment has been minimized.
This comment has been minimized.
|
Is it possible to call the super class forward method in the derived class forward method? |
This comment has been minimized.
This comment has been minimized.
|
super is not support and it will take some time before we can support it. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zdevito commentedMay 14, 2019
•
edited
Stack from ghstack:
Summary: Previously, we registered script modules of parent classes during their init methods, making it impossible
to correctly 'override' a method or leave it blank in a subclass. This diff adds the functionality by waiting
until the child init is finished before registering all the methods.
Test Plan: python test/test_jit.py
Differential Revision: D15341555