Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unwrap logic from c10 to caffe2 #21620

Closed

Conversation

Projects
None yet
4 participants
@yf225
Copy link
Contributor

commented Jun 10, 2019

After #17072, we are allowed to pass Variables into ATen ops, thus there is no need to unwrap input variables in the c10 call path.

Note that since Caffe2 still expects inputs to be pure Tensors, we moved the unwrapping logic to the Caffe2 wrapper.

@yf225 yf225 requested a review from smessmer Jun 10, 2019

@smessmer
Copy link
Contributor

left a comment

looks great, thanks.

@facebook-github-bot
Copy link
Contributor

left a comment

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225 yf225 referenced this pull request Jun 11, 2019

Open

Variable/Tensor Merge Proposal #13638

15 of 22 tasks complete
@facebook-github-bot
Copy link
Contributor

left a comment

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

left a comment

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

@yf225 merged this pull request in 04f09d4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.