Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable non-deterministic cudnn ctcloss #22977

Closed

Conversation

nairbv
Copy link
Collaborator

@nairbv nairbv commented Jul 17, 2019

Associated issue: #21680

@gchanan
Copy link
Contributor

gchanan commented Jul 17, 2019

FYI: I'm not sure if writing "Associated issue" will automatically close the issue, but writing "Fixes: " will.

@@ -364,7 +364,7 @@ Tensor ctc_loss(const Tensor& log_probs, const Tensor& targets, IntArrayRef inpu

Tensor res;
if (use_cudnn) {
res = std::get<0>(at::_cudnn_ctc_loss(log_probs, targets, input_lengths, target_lengths, BLANK, ctx.deterministicCuDNN(), zero_infinity));
res = std::get<0>(at::_cudnn_ctc_loss(log_probs, targets, input_lengths, target_lengths, BLANK, true, zero_infinity));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deserves a comment?

@@ -364,7 +364,7 @@ Tensor ctc_loss(const Tensor& log_probs, const Tensor& targets, IntArrayRef inpu

Tensor res;
if (use_cudnn) {
res = std::get<0>(at::_cudnn_ctc_loss(log_probs, targets, input_lengths, target_lengths, BLANK, ctx.deterministicCuDNN(), zero_infinity));
res = std::get<0>(at::_cudnn_ctc_loss(log_probs, targets, input_lengths, target_lengths, BLANK, true, zero_infinity));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you just add a comment explaining the issue?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nairbv is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 18, 2019
Summary:
Associated issue: pytorch/pytorch#21680
Pull Request resolved: pytorch/pytorch#22977

Differential Revision: D16357873

Pulled By: nairbv

fbshipit-source-id: 58711bac7d3e8390e868d594dc265ba053a1537c
@facebook-github-bot
Copy link
Contributor

@nairbv merged this pull request in 0c09138.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants