Fully deprecate variadic inputs of checkpoint_sequential - #25985
Closed
sublee wants to merge 8 commits into
Closed
Conversation
pytorchbot
added
module: activation checkpointing
soumith
approved these changes
Sep 24, 2019
Collaborator
|
@pytorchbot rebase this please |
Contributor
Author
|
@soumith Thank you for reviewing it. |
Contributor
|
@sublee We can't land it yet because test is failing: |
Contributor
Author
vincentqb
added
the
triaged
Contributor
Author
|
@soumith I guess you lost the last update. Would you please review this PR again? |
sublee
force-pushed
the
deprecate-checkpoint-sequential-varargs
branch
from
October 11, 2019 11:15
aa20b4a to
a07700f
Compare
Contributor
Author
|
This patch was intended to deploy with v1.3.0. However, today PyTorch v1.3.0 has been released. I update the version to v1.4 in the deprecation documentation and rebase this branch onto the current |
albanD
approved these changes
Dec 3, 2019
albanD
left a comment
albanD
left a comment
Collaborator
There was a problem hiding this comment.
Details in the test to make it look slightly better.
Then I'll merge.
Thanks for the PR !
albanD
force-pushed
the
deprecate-checkpoint-sequential-varargs
branch
from
December 4, 2019 15:08
01bf464 to
e61b020
Compare
Collaborator
|
Just rebased on top of master for CI. And again as I rebased on top of a broken master... |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
It was intended to deploy with v1.3.0 but late.
albanD
force-pushed
the
deprecate-checkpoint-sequential-varargs
branch
from
December 4, 2019 16:18
e61b020 to
5829119
Compare
soumith
approved these changes
Dec 4, 2019
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@albanD is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: To support variadic inputs of `checkpoint_sequential` was deprecated at pytorch#21006. This case should be warned with `DeprecationWarning` for PyTorch 1.2, but it should be simply failed with `TypeError` since PyTorch 1.3. This patch removes the `DeprecationWarning` for PyTorch 1.2. Pull Request resolved: pytorch#25985 Differential Revision: D18809875 Pulled By: albanD fbshipit-source-id: e84dd8629c04979c4b2dc63e8ada94292e8cedd0
Contributor
|
Hmm, If I am understanding this correctly it is not BC breaking because it enables behavior that used to throw a TypeError |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: To support variadic inputs of `checkpoint_sequential` was deprecated at pytorch#21006. This case should be warned with `DeprecationWarning` for PyTorch 1.2, but it should be simply failed with `TypeError` since PyTorch 1.3. This patch removes the `DeprecationWarning` for PyTorch 1.2. Pull Request resolved: pytorch#25985 Differential Revision: D18809875 Pulled By: albanD fbshipit-source-id: e84dd8629c04979c4b2dc63e8ada94292e8cedd0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support variadic inputs of
checkpoint_sequentialwas deprecated at #21006. This case should be warned withDeprecationWarningfor PyTorch 1.2, but it should be simply failed withTypeErrorsince PyTorch 1.3. This patch removes theDeprecationWarningfor PyTorch 1.2.