Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native ctc_loss gradient indexing bug for large target sizes #27460

Closed
wants to merge 1 commit into from

Conversation

@t-vi
Copy link
Collaborator

t-vi commented Oct 7, 2019

Fixes: #27442

Thank you Mohamed Yousef (@ASDen) for the report with minimal
reproducing example and detailed analysis!

Fixes: #27442

Thank you Mohamed Yousef (@ASDen) for the report with minimal
reproducing example and detailed analysis!
@soumith
soumith approved these changes Oct 7, 2019
Copy link
Contributor

facebook-github-bot left a comment

@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@t-vi

This comment has been minimized.

Copy link
Collaborator Author

t-vi commented Oct 9, 2019

@soumith Something seems to have gone wrong with landing this(?).

zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 10, 2019
…460)

Summary:
Fixes: pytorch/pytorch#27442

Thank you Mohamed Yousef (ASDen) for the report with minimal
reproducing example and detailed analysis!
Pull Request resolved: pytorch/pytorch#27460

Differential Revision: D17789378

Pulled By: soumith

fbshipit-source-id: dc01a31b998cced4462e933d4b32e09b331f7e41
@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

facebook-github-bot commented Oct 10, 2019

@soumith merged this pull request in e66e00c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.