Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include hierarchy information in C++ API loading error messages #28499

Closed
wants to merge 2 commits into from

Conversation

@t-vi
Copy link
Collaborator

t-vi commented Oct 23, 2019

Before, we would only give the key we are looking for (i.e. typically
just "No such serialized tensor 'weight'", no matter for which submodule
we were looking for a weight.
Now we error with "No such serialized tensor '0.conv1.weight'" or
similar.
The analogous information is added to missing module error messages.

I threw in a test, and it saved me already...

Before, we would only give the key we are looking for (i.e. typically
just "No such serialized tensor 'weight'", no matter for which submodule
we were looking for a weight.
Now we error with "No such serialized tensor '0.conv1.weight'" or
similar.
The analogous information is added to missing module error messages.

I threw in a test, and it saved me already...
@t-vi t-vi requested a review from yf225 Oct 23, 2019
@t-vi t-vi requested review from ebetica and goldsborough as code owners Oct 23, 2019
@yf225
yf225 approved these changes Oct 23, 2019
Copy link
Contributor

yf225 left a comment

@t-vi Thanks a lot for the nice improvement!

@albanD
albanD approved these changes Oct 23, 2019
Copy link
Contributor

facebook-github-bot left a comment

@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@t-vi

This comment has been minimized.

Copy link
Collaborator Author

t-vi commented Oct 30, 2019

@yf225 This seems to be stalled. Would it help if I rebased?

@yf225

This comment has been minimized.

Copy link
Contributor

yf225 commented Oct 30, 2019

@t-vi Sorry it was my fault - let me try to land again and see if it works. Thanks so much for your help Thomas!

@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

facebook-github-bot commented Oct 30, 2019

@yf225 merged this pull request in 2526f97.

v0dro added a commit to v0dro/pytorch that referenced this pull request Nov 25, 2019
…rch#28499)

Summary:
Before, we would only give the key we are looking for (i.e. typically
just "No such serialized tensor 'weight'", no matter for which submodule
we were looking for a weight.
Now we error with "No such serialized tensor '0.conv1.weight'" or
similar.
The analogous information is added to missing module error messages.

I threw in a test, and it saved me already...
Pull Request resolved: pytorch#28499

Differential Revision: D18122442

Pulled By: yf225

fbshipit-source-id: a134b6d06ca33de984a11d6fea923244bcd9fb95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.