Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate torch::nn::modules_ordered_dict API #28774

Closed
wants to merge 3 commits into from

Conversation

yf225
Copy link
Contributor

@yf225 yf225 commented Oct 28, 2019

I finally found a way to get the following API to work for constructing a list of named submodules for Sequential:

Sequential sequential({
  {"m1", MyModule(1)},
  {"m2", MyModule(2)}
})`

which was actually our original proposed design and much simpler than our current API:

Sequential sequential(modules_ordered_dict({
  {"m1", MyModule(1)},
  {"m2", MyModule(2)}
}));

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@yf225 merged this pull request in 5804e54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants