[quantization] Fix BC for quantized linear #30481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
jamesr66a
pushed a commit
that referenced
this pull request
Nov 26, 2019
ghstack-source-id: edbefa8a5bb27e7e79da5c56e04c7ca7d233e441 Pull Request resolved: #30481
| @@ -136,6 +137,14 @@ def _load_from_state_dict(self, state_dict, prefix, local_metadata, strict, | |||
| self.zero_point = int(state_dict[prefix + 'zero_point']) | |||
| state_dict.pop(prefix + 'zero_point') | |||
|
|
|||
| version = local_metadata.get('version', None) | |||
| if version is None or version == 1: | |||
There was a problem hiding this comment.
For my understanding: Do we need to check for version ==1? We dont have this field currently.
There was a problem hiding this comment.
I think it's better to be explicit, for example in the forward-compatiblity case. It would be an error to enter this branch if someone's loading a newer model, and that would lead to some pretty weird errors
There was a problem hiding this comment.
Newer models will have version >= 2 right?
raghuramank100
approved these changes
Nov 26, 2019
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#30481 Test Plan: Imported from OSS Differential Revision: D18714602 Pulled By: jamesr66a fbshipit-source-id: d51206c22cf2446e98053446789c6324c0481321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18714602