Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Im2col export #30972

Closed
wants to merge 12 commits into from
Closed

Conversation

neginraoof
Copy link
Contributor

@neginraoof neginraoof commented Dec 9, 2019

Added im2col to opset 11.
This symbolic is used to export torch.nn.Unfold

@neginraoof
Copy link
Contributor Author

cc @BowenBao @lara-hdr
Please review

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the code is very clean. Just some minor comments.

test/onnx/test_pytorch_onnx_onnxruntime.py Outdated Show resolved Hide resolved
torch/onnx/symbolic_opset11.py Show resolved Hide resolved
torch/onnx/symbolic_opset11.py Outdated Show resolved Hide resolved
torch/onnx/symbolic_opset11.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torch/onnx/symbolic_opset11.py Outdated Show resolved Hide resolved
@neginraoof
Copy link
Contributor Author

@houseroad PR is approved and ready. Could you please take a look?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in 0b57b38.

wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary:
Added im2col to opset 11.
This symbolic is used to export torch.nn.Unfold
Pull Request resolved: pytorch#30972

Reviewed By: hl475

Differential Revision: D18946921

Pulled By: houseroad

fbshipit-source-id: 13dd0cbae899700df32fd74d6dff1f29033a2b4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants