Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Constant Folding for ONNX Opset 12 #34823

Closed

Conversation

@lara-hdr
Copy link
Member

lara-hdr commented Mar 16, 2020

Currently constant folding is only enabled for ONNX opset versions 9 to 11. This PR enables it for the new ONNX opset 12.

@lara-hdr lara-hdr requested a review from apaszke as a code owner Mar 16, 2020
@dr-ci
Copy link

dr-ci bot commented Mar 16, 2020

💊 CircleCI build failures summary and remediations

As of commit d4f57c6 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 14 times.

@lara-hdr lara-hdr requested a review from neginraoof Mar 18, 2020
Copy link
Collaborator

neginraoof left a comment

Looks good! Thanks for fixing slice as well :)

@KsenijaS
Copy link
Collaborator

KsenijaS commented Mar 24, 2020

looks good

@lara-hdr
Copy link
Member Author

lara-hdr commented Mar 24, 2020

@houseroad this is approved

Copy link
Contributor

facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad
Copy link
Member

houseroad commented Mar 24, 2020

Please request my review or cc me, otherwise, I might not be aware it :-)

Copy link
Member

houseroad left a comment

Looks good, thanks

@lara-hdr
Copy link
Member Author

lara-hdr commented Mar 25, 2020

@houseroad can we merge this?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 25, 2020

@houseroad merged this pull request in 7e327e1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.